Bug in server log viewer

[gilles]

There seems to be a bug in the server log viewer. The SetRange function in admin/html.open/lib/LogViewer.php prevents $from from being set to -1, which is POS_FILEEND ie the end of the file. Therefore the |> button does not really work.

function SetRange($from, $size)
{
if ($from < 0)
$from = 0; // <-- This is wrong

which also breaks the code below in the same file:

public static function GetDashErrLog($errorlogfile)
{
$filter = new LogFilter($errorlogfile);
$filter->Set(LogFilter::FLD_LEVEL, LogFilter::LEVEL_NOTICE);
$filter->SetRange(LogFilter :: POS_FILEEND, 20); // <-- This won't work because POS_FILEEND is -1!

Please advice and fix. And also, how do I disable auto-smiley replacement

 

[gilles]

Removing the faulty if statement fix the server log viewer both on the dashboard and on the server viewer page.

 

[gilles]

@Cold-Egg: I would like to get your take on this (what I think is a) bug. Thanks

 

[gilles]

Filed on github as: https://github.com/litespeedtech/openlitespeed/issues/197

 

[Cold-Egg]

Thanks for your contribution. One of the developer will take a look maybe tomorrow.